This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [GCC][PATCH][TESTSUITE][ARM][COMMITTED] Invert check to misalign in vect_hw_misalign (PR 78421)
- From: Christophe Lyon <christophe dot lyon at linaro dot org>
- To: Mike Stump <mikestump at comcast dot net>
- Cc: Tamar Christina <tamar dot christina at arm dot com>, "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>, nd <nd at arm dot com>, Ramana Radhakrishnan <Ramana dot Radhakrishnan at arm dot com>, Richard Earnshaw <Richard dot Earnshaw at arm dot com>, nick clifton <nickc at redhat dot com>, Kyrylo Tkachov <Kyrylo dot Tkachov at arm dot com>
- Date: Tue, 26 Sep 2017 06:58:58 +0200
- Subject: Re: [GCC][PATCH][TESTSUITE][ARM][COMMITTED] Invert check to misalign in vect_hw_misalign (PR 78421)
- Authentication-results: sourceware.org; auth=none
- References: <20170921144831.GA24114@arm.com> <CAKdteOZFw6GJkJXxyxF8Pn+m-EAeeXN6A_rRnfcNcKHkpvPU1A@mail.gmail.com> <CAKdteOaqWoXtUGggE9VQHhb=eYT+UkR1ETFdDdF_U6HvnwhS8g@mail.gmail.com> <43ACF6E7-7079-4DF9-B714-89A41AD1934C@comcast.net>
On 25 September 2017 at 20:19, Mike Stump <mikestump@comcast.net> wrote:
> On Sep 23, 2017, at 10:52 AM, Christophe Lyon <christophe.lyon@linaro.org> wrote:
>> The attached patch would apply after reverting yours.
>> I've applied it against r253072 (just before your patch) and the
>> results are visible at:
>> http://people.linaro.org/~christophe.lyon/cross-validation/gcc-test-patches/253072-hw-misalign2/report-build-info.html
>>
>> Do they match your expectations? It looks like a few testcases need to
>> be adjusted,
>> or new bugs are uncovered.
>>
>> If the patch OK with a suitable ChangeLog entry?
>
> So, I wasn't sure what you meant by the comment. Below is an example of ! working.
>
> % proc b {} { return 0 }
> % set v [expr ![b]]
> 1
> % set v [ expr !![b]]
> 0
> % proc b {} { return 1 }
> % set v [expr ![b]]
> 0
> % set v [ expr !![b]]
> 1
>
> Given that, if you want to use a simple set var value, you should just do that directly. [b] is the placeholder for an [] expression, if you want to invert that. v is the placeholder for the thing you want to set. All the other bits should be used as given. Given that code, I'd be interested in what you want to put in the comment, if any.
>
> set et_vect_hw_misalign_saved($et_index) [expr ![check_effective_target_arm_vect_no_misalign]]
>
> seems like what you want, does that work?
>
Yes, thanks! I was missing the 'expr' part.
Here is what I have committed (r253187), to avoid further noise in the results.
2017-09-26 Christophe Lyon <christophe.lyon@linaro.org>
* lib/target-supports.exp (check_effective_target_vect_hw_misalign):
Fix arm check.
* lib/target-supports.exp
Index: gcc/testsuite/lib/target-supports.exp
===================================================================
--- gcc/testsuite/lib/target-supports.exp (revision 253186)
+++ gcc/testsuite/lib/target-supports.exp (working copy)
@@ -5951,7 +5951,7 @@
set et_vect_hw_misalign_saved($et_index) 1
}
if { [istarget arm*-*-*] } {
- set et_vect_hw_misalign_saved($et_index)
![check_effective_target_arm_vect_no_misalign]
+ set et_vect_hw_misalign_saved($et_index) [expr
![check_effective_target_arm_vect_no_misalign]]
}
}
verbose "check_effective_target_vect_hw_misalign:\
Thanks,
Christophe