This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [GCC][PATCH][TESTSUITE][ARM][COMMITTED] Invert check to misalign in vect_hw_misalign (PR 78421)
- From: Christophe Lyon <christophe dot lyon at linaro dot org>
- To: Tamar Christina <Tamar dot Christina at arm dot com>
- Cc: "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>, nd <nd at arm dot com>, Ramana Radhakrishnan <Ramana dot Radhakrishnan at arm dot com>, Richard Earnshaw <Richard dot Earnshaw at arm dot com>, "nickc at redhat dot com" <nickc at redhat dot com>, Kyrylo Tkachov <Kyrylo dot Tkachov at arm dot com>, Mike Stump <mikestump at comcast dot net>
- Date: Mon, 25 Sep 2017 14:52:14 +0200
- Subject: Re: [GCC][PATCH][TESTSUITE][ARM][COMMITTED] Invert check to misalign in vect_hw_misalign (PR 78421)
- Authentication-results: sourceware.org; auth=none
- References: <20170921144831.GA24114@arm.com> <CAKdteOZFw6GJkJXxyxF8Pn+m-EAeeXN6A_rRnfcNcKHkpvPU1A@mail.gmail.com> <CAKdteOaqWoXtUGggE9VQHhb=eYT+UkR1ETFdDdF_U6HvnwhS8g@mail.gmail.com> <HE1PR0802MB23160C05DF808C173DB24D13FF7A0@HE1PR0802MB2316.eurprd08.prod.outlook.com>
On 25 September 2017 at 11:36, Tamar Christina <Tamar.Christina@arm.com> wrote:
>
>
>> -----Original Message-----
>> From: Christophe Lyon [mailto:christophe.lyon@linaro.org]
>> Sent: 23 September 2017 18:52
>> To: Tamar Christina
>> Cc: gcc-patches@gcc.gnu.org; nd; Ramana Radhakrishnan; Richard Earnshaw;
>> nickc@redhat.com; Kyrylo Tkachov
>> Subject: Re: [GCC][PATCH][TESTSUITE][ARM][COMMITTED] Invert check to
>> misalign in vect_hw_misalign (PR 78421)
>>
>> On 23 September 2017 at 16:12, Christophe Lyon
>> <christophe.lyon@linaro.org> wrote:
>> > On 21 September 2017 at 16:48, Tamar Christina
>> <tamar.christina@arm.com> wrote:
>> >> Hi All,
>> >>
>> >> Commit r244796 changed vect_hw_misalign for arm to check against
>> >> arm_vect_no_misalign. However vect_hw_misalign is supposed to check
>> >> if a target supports misalign access, while arm_vect_no_misalign
>> >> checks that a target only supports aligned access.
>> >>
>> >> As such the results need to be inverted otherwise the test runs in
>> >> exactly the wrong circumstances.
>> >>
>> >> Committed as r253073 under the GCC obvious rule.
>> >
>> > Hi Tamar,
>> >
>
> Hi Christoph,
>
>> > This is not as obvious as we might think. This patch is causing tcl
>> > syntax errors, such as:
>> > error executing dg-final: expected boolean value but got "!1"
>> >
>
> Ack, I didn't see this before, I only checked for tests using arm_vect_no_misalign and retested those and the few
> That were failing before. Sorry about that.
>
The tcl error messages may be difficult to notice, they tend to be
"hidden" in the middle of the logs.
>> > I plan to send a fix b/o next week.
>> >
>>
>> The attached patch would apply after reverting yours.
>> I've applied it against r253072 (just before your patch) and the results are
>> visible at:
>> http://people.linaro.org/~christophe.lyon/cross-validation/gcc-test-
>> patches/253072-hw-misalign2/report-build-info.html
>>
>> Do they match your expectations? It looks like a few testcases need to be
>> adjusted, or new bugs are uncovered.
>>
>> If the patch OK with a suitable ChangeLog entry?
>
> That looks OK to me, about ~40 new tests correctly run now, and I think the new failures are just test-isms but I'll
> Look at them more closely today.
>
Thanks for taking a look.
I've added Mike in cc so that he can confirm my patch is right. There
might be a better tcl idiom....
Thanks,
Christophe
> Thanks,
> Tamar
>
>>
>> Thanks,
>>
>> Christophe
>>
>> > Christophe
>> >
>> >>
>> >> Thanks,
>> >> Tamar
>> >>
>> >> gcc/ChangeLog
>> >> 2017-09-21 Tamar Christina <tamar.christina@arm.com>
>> >>
>> >> PR testsuite/78421
>> >> * lib/target-supports.exp
>> (check_effective_target_vect_hw_misalign):
>> >> Invert arm check.
>> >>
>> >> --