This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Better fix for the x86_64 -mcmodel=large ICEs (PR target/82145)
- From: Jakub Jelinek <jakub at redhat dot com>
- To: Uros Bizjak <ubizjak at gmail dot com>
- Cc: Richard Biener <rguenther at suse dot de>, Jeff Law <law at redhat dot com>, "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>
- Date: Sun, 17 Sep 2017 19:27:31 +0200
- Subject: Re: [PATCH] Better fix for the x86_64 -mcmodel=large ICEs (PR target/82145)
- Authentication-results: sourceware.org; auth=none
- Authentication-results: ext-mx10.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
- Authentication-results: ext-mx10.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=jakub at redhat dot com
- Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 342A05D5EA
- References: <20170913103224.GV1701@tucnak> <alpine.LSU.2.20.1709131248190.26836@zhemvz.fhfr.qr> <CAFULd4aoFJstDV-Kk168+nJ5coLpV+h7VBAs1NrZB0XbVYvivg@mail.gmail.com>
- Reply-to: Jakub Jelinek <jakub at redhat dot com>
On Sun, Sep 17, 2017 at 05:47:11PM +0200, Uros Bizjak wrote:
> > The postreload change is ok.
>
> The revert is OK even without approval.
Well, it isn't a pure reversion, it is reversion plus addition of
const char *name = LABEL_NAME (label);
PUT_CODE (label, NOTE);
NOTE_KIND (label) = NOTE_INSN_DELETED_LABEL;
NOTE_DELETED_LABEL_NAME (label) = name;
to the end of ix86_init_large_pic_reg.
> >> 2017-09-13 Jakub Jelinek <jakub@redhat.com>
> >>
> >> PR target/82145
> >> * postreload.c (reload_cse_simplify_operands): Skip
> >> NOTE_INSN_DELETED_LABEL similarly to skipping CODE_LABEL.
> >> * config/i386/i386.c (ix86_init_large_pic_reg): Revert 2017-09-01
> >> changes. Turn CODE_LABEL into NOTE_INSN_DELETED_LABEL immediately.
> >> (ix86_init_pic_reg): Revert 2017-09-01 changes.
> >>
> >> * gcc.target/i386/pr82145.c: New test.
Jakub