This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [RFC][PATCH 1/5] Add separate parms for rtl unroller
- From: Richard Biener <richard dot guenther at gmail dot com>
- To: Kugan Vivekanandarajah <kugan dot vivekanandarajah at linaro dot org>
- Cc: "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>
- Date: Fri, 15 Sep 2017 11:31:19 +0200
- Subject: Re: [RFC][PATCH 1/5] Add separate parms for rtl unroller
- Authentication-results: sourceware.org; auth=none
- References: <CAELXzTMdH_scC+o3xFy2mBTakFDohccDLF8ZgX1AcSS03s7k7Q@mail.gmail.com>
On Fri, Sep 15, 2017 at 3:27 AM, Kugan Vivekanandarajah
<kugan.vivekanandarajah@linaro.org> wrote:
> This patch adds separate params for rtl unroller so that they can be
> tunned accordingly. Default values I have are based on some testing on
> aarch64. I am happy to leave it as the current value and set them in
> the back-end.
PARAM_MAX_AVERAGE_UNROLLED_INSNS is only used by the RTL
unroller. Why should we separate PARAM_MAX_UNROLL_TIMES?
PARAM_MAX_UNROLLED_INSNS is only used by gimple passes
that perform unrolling. Since GIMPLE is three-address it should
match RTL reasonably well -- but I'd be ok in having a separate param
for those. But I wouldn't name those 'partial'.
That said, those are magic numbers and I expect we can find some
that work well on RTL and GIMPLE.
Richard.
>
> Thanks,
> Kugan
>
>
> gcc/ChangeLog:
>
> 2017-09-12 Kugan Vivekanandarajah <kuganv@linaro.org>
>
> * loop-unroll.c (decide_unroll_constant_iterations): Use new params.
> (decide_unroll_runtime_iterations): Likewise.
> (decide_unroll_stupid): Likewise.
> * params.def (DEFPARAM): Separate and add new params for rtl unroller.