This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Fix PR 81096 (ttest failures)
- From: Steve Ellcey <sellcey at cavium dot com>
- To: Ian Lance Taylor <iant at google dot com>, Wilco Dijkstra <Wilco dot Dijkstra at arm dot com>
- Cc: "Ellcey, Steve" <Steve dot Ellcey at cavium dot com>, GCC Patches <gcc-patches at gcc dot gnu dot org>, nd <nd at arm dot com>
- Date: Tue, 12 Sep 2017 09:49:52 -0700
- Subject: Re: [PATCH] Fix PR 81096 (ttest failures)
- Authentication-results: sourceware.org; auth=none
- Authentication-results: spf=none (sender IP is ) smtp.mailfrom=Steve dot Ellcey at cavium dot com;
- References: <HE1PR0801MB2058A2A0C0EAD10AE0E22D4483690@HE1PR0801MB2058.eurprd08.prod.outlook.com> <CAKOQZ8ww+TUviTW1MUf3Dufrs0vUvEDekF4dQS4CgBUWd9XMrg@mail.gmail.com>
- Reply-to: sellcey at cavium dot com
- Spamdiagnosticmetadata: NSPM
- Spamdiagnosticoutput: 1:99
On Tue, 2017-09-12 at 09:39 -0700, Ian Lance Taylor wrote:
> On Tue, Sep 12, 2017 at 3:59 AM, Wilco Dijkstra <Wilco.Dijkstra@arm.c
> om> wrote:
> >
> > Steve Ellcey wrote:
> > >
> > > This patch fixes the ttest failures on aarch64 by adding
> > > AM_CFLAGS to
> > > the test options, like btest already does and as Wilco says works
> > > for
> > > him in Comment #4 of the bug report.
> > Thanks for picking this up, this looks OK.
> >
> > >
> > > Tested by me on aarch64. Ok to checkin?
> > This counts as an obvious fix, so you can commit it.
> Wait, what? This patch is at best incomplete. Makefile.in is a
> generated file. You need to change Makefile.am and re-run automake.
>
> Ian
OK, here is the new patch that I will checkin. I verified that after
running automake on Makefile.am, the Makefile.in I got was identical
to what I checked in earlier.
Steve Ellcey
sellcey@cavium.com
2017-09-12 Steve Ellcey <sellcey@cavium.com>
PR other/81096
* Makefile.am (ttest_CFLAGS): Add $(AM_CFLAGS)
* Makefile.in: Regenerate.
diff --git a/libbacktrace/Makefile.am b/libbacktrace/Makefile.am
index b91d6bc..120beb1 100644
--- a/libbacktrace/Makefile.am
+++ b/libbacktrace/Makefile.am
@@ -117,7 +117,7 @@ if HAVE_PTHREAD
check_PROGRAMS += ttest
ttest_SOURCES = ttest.c testlib.c
-ttest_CFLAGS = -pthread
+ttest_CFLAGS = $(AM_CFLAGS) -pthread
ttest_LDADD = libbacktrace.la
endif HAVE_PTHREAD