This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [C PATCH] field_decl_cmp
- From: Joseph Myers <joseph at codesourcery dot com>
- To: Nathan Sidwell <nathan at acm dot org>
- Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>
- Date: Tue, 12 Sep 2017 16:06:00 +0000
- Subject: Re: [C PATCH] field_decl_cmp
- Authentication-results: sourceware.org; auth=none
- References: <68b46c41-a333-7273-fe12-ae395d642ccb@acm.org>
On Tue, 12 Sep 2017, Nathan Sidwell wrote:
> Joseph,
> in moving field_decl_cmp to the C FE, I noticed it checks for NULL DECL_NAMES.
> Those don't occur.
To be clear: they don't occur in the case where field_decl_cmp is used;
they can occur in other cases.
> This patch removes that checking, and also asserts that when we see
> identically named decls, exactly one is a TYPE_DECL.
When do you get TYPE_DECLs here, for C? I wouldn't expect them to be
possible.
--
Joseph S. Myers
joseph@codesourcery.com