This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] fix PR translation/82185
- From: Max Filippov <jcmvbkbc at gmail dot com>
- To: Max Filippov <jcmvbkbc at gmail dot com>, "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>, Richard Sandiford <richard dot sandiford at linaro dot org>
- Date: Mon, 11 Sep 2017 14:59:08 -0700
- Subject: Re: [PATCH] fix PR translation/82185
- Authentication-results: sourceware.org; auth=none
- References: <1505164538-25675-1-git-send-email-jcmvbkbc@gmail.com> <871sncdiix.fsf@linaro.org>
Hi Richard,
On Mon, Sep 11, 2017 at 2:36 PM, Richard Sandiford
<richard.sandiford@linaro.org> wrote:
> Max Filippov <jcmvbkbc@gmail.com> writes:
>> 2017-09-11 Max Filippov <jcmvbkbc@gmail.com>
>> gcc/
>> * expmed.c (emit_store_flag_int): Initialize rtx tem.
>
> LGTM, thanks, but I can't approve it.
>
> This makes the later "tem = 0;" redundant, so perhaps it would make
> sense to delete that too? There again, it was redundant before the
> split as well.
>
> An alternative would be to only test tem when we've done something
> with it, as below, but I don't know if that's better or a step backwards.
this works for me too, so whichever fix you like better.
--
Thanks.
-- Max