This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH 02/22] libcpp: add linemap_position_for_file_line_and_column
- From: Jeff Law <law at redhat dot com>
- To: David Malcolm <dmalcolm at redhat dot com>, gcc-patches at gcc dot gnu dot org
- Date: Fri, 1 Sep 2017 11:50:21 -0600
- Subject: Re: [PATCH 02/22] libcpp: add linemap_position_for_file_line_and_column
- Authentication-results: sourceware.org; auth=none
- Authentication-results: ext-mx02.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
- Authentication-results: ext-mx02.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=law at redhat dot com
- Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 827D4806BD
- References: <1501884293-9047-1-git-send-email-dmalcolm@redhat.com> <1501884293-9047-3-git-send-email-dmalcolm@redhat.com>
On 08/04/2017 04:04 PM, David Malcolm wrote:
> gcc/ChangeLog:
> * input.c (selftest::test_making_arbitrary_locations): New function.
> (selftest::input_c_tests): Call it.
>
> libcpp/ChangeLog:
> * include/line-map.h (linemap_position_for_file_line_and_column):
> New decl.
> * line-map.c (linemap_position_for_file_line_and_column): New
> function.
SImilarly. No concerns. Go with it when it makes sense.
jeff