This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH 01/22] Expose assert_loceq outside of input.c; add ASSERT_LOCEQ
- From: Jeff Law <law at redhat dot com>
- To: David Malcolm <dmalcolm at redhat dot com>, gcc-patches at gcc dot gnu dot org
- Date: Fri, 1 Sep 2017 11:49:19 -0600
- Subject: Re: [PATCH 01/22] Expose assert_loceq outside of input.c; add ASSERT_LOCEQ
- Authentication-results: sourceware.org; auth=none
- Authentication-results: ext-mx07.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
- Authentication-results: ext-mx07.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=law at redhat dot com
- Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 982FFC034E7B
- References: <1501884293-9047-1-git-send-email-dmalcolm@redhat.com> <1501884293-9047-2-git-send-email-dmalcolm@redhat.com>
On 08/04/2017 04:04 PM, David Malcolm wrote:
> gcc/ChangeLog:
> * input.c: Include "selftest-input.h".
> (selftest::assert_loceq): Remove "static". Add "report_loc" param
> and update assertions to use it.
> (selftest::test_accessing_ordinary_linemaps): Use ASSERT_LOCEQ
> rather than assert_loceq.
> (selftest::test_builtins): Likewise.
> * selftest-input.h: New file.
No concerns here. IMHO this is all probably within an area that I think
you could argue for self-approval.
jeff