This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Patch for [Bug fortran/81841] [5/6/7/8 Regression] THREADPRIVATE (OpenMP) wrongly rejected in BLOCK DATA
- From: dbroemmel <dibr-bugzilla at daswigwam dot de>
- To: Jakub Jelinek <jakub at redhat dot com>
- Cc: fortran at gcc dot gnu dot org, gcc-patches at gcc dot gnu dot org
- Date: Fri, 1 Sep 2017 15:47:10 +0200
- Subject: Re: Patch for [Bug fortran/81841] [5/6/7/8 Regression] THREADPRIVATE (OpenMP) wrongly rejected in BLOCK DATA
- Authentication-results: sourceware.org; auth=none
- References: <2f2d738f-90d7-0efe-1caf-7e3a6387b0eb@daswigwam.de> <20170901120842.GJ2323@tucnak> <a7154299-b247-86ef-8c99-c4c508e9f7c3@daswigwam.de> <20170901131124.GK2323@tucnak>
> If you really need a testcase, it would be enough to do something like:
> use omp_lib
> !$omp parallel num_threads(2)
> int2 = omp_get_thread_num ()
> !$omp barrier
> if (int2 != omp_get_thread_num ()) call abort
> !$omp end parallel
> or so to ensure it has the threadprivate property by writing something
> different to it in each thread and after barrier verifying it has the
> expected value in each thread.
I'm more than fine with the short compile-only testcase. I pretty sure
my largish runtime test doesn't get near covering all relevant aspects
of the THREADPRIVATE directive for common blocks. Also, the fix is for
this reject-valid parsing error, so not really to do with anything else,
so perhaps shouldn't test anything else?
Dirk