This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Adjust function name dumping


Richard,

> When enabling free-lang-data the lang_hooks.decl_printable_name hook
> gets reset.  The following patch reduces the noise from that by
> using verbosity 1 (do not print arguments) from the places where
> we dump the function name and then follow by arguments manually.
> 
> This makes dumping consistent with calls in the IL so you can
> cut&paste & search in dumps easier (Ada dumps had case differences
> for example).  This requires a few changes in the testsuite dump scans
> (but not too many to make the change controversical).
> 
> Bootstrapped and tested on x86_64-unknown-linux-gnu, applied to trunk.
> 
> Richard.
> 
> 2017-08-23  Richard Biener  <rguenther@suse.de>
> 
> 	* function.c (fndecl_name): Use verbosity 1 (no arguments) for
> 	lang_hooks.decl_printable_name.
> 	* print-rtl-function.c (print_rtx_function): Likewise.
> 	* tree-pretty-print.c (dump_function_header): Likewise.
> 
> 	* g++.dg/cpp1y/constexpr-instantiate.C: Adjust.
> 	* g++.dg/tree-ssa/pr45605.C: Likewise.
> 	* gnat.dg/noinline2.ad: Likewise.b
> 	* gnat.dg/renaming6.ad: Likewise.b
> 	* gnat.dg/renaming6.ad: Likewise.s
> 	* gnat.dg/specs/noinline3.ad: Likewise.s

You have typos in the a bove changelog BTW, the "b" and "s" should be
part of the filenames (e.g. gnat.dg/noinline2.adb: Likewise.)

I do not understand the changes in the ada testsuite: cana you explain why
you renames some variables?

Arno


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]