This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH, rs6000] More diagnostic cleanup, addressing PR79845
- From: Bill Schmidt <wschmidt at linux dot vnet dot ibm dot com>
- To: Martin Sebor <msebor at gmail dot com>
- Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>, Segher Boessenkool <segher at kernel dot crashing dot org>, David Edelsohn <dje dot gcc at gmail dot com>
- Date: Mon, 14 Aug 2017 09:21:51 -0500
- Subject: Re: [PATCH, rs6000] More diagnostic cleanup, addressing PR79845
- Authentication-results: sourceware.org; auth=none
- References: <e6da7858-91d3-8b4b-8686-b6591dbd902f@linux.vnet.ibm.com> <390c9e90-30d5-d06a-1129-219afe999be2@gmail.com>
> On Aug 13, 2017, at 3:41 PM, Martin Sebor <msebor@gmail.com> wrote:
>
>> --- gcc/config/rs6000/rs6000-c.c (revision 250965)
>> +++ gcc/config/rs6000/rs6000-c.c (working copy)
>> @@ -5812,7 +5812,7 @@ altivec_resolve_overloaded_builtin (location_t loc
>> types. */
>> if (nargs != 2)
>> {
>> - error ("vec_mul only accepts 2 arguments");
>> + error ("builtin %qs only accepts 2 arguments", "vec_mul");
>
> I don' meant to nit-pick too much but it has been drilled into me
> that the term is built-in, not builtin. There are a number of
> deviations from this preferred spelling in GCC messages already
> (mainly though not exclusively in the rs600 back-end) but I think
> it would be nice to converge on the preferred spelling.
Martin, while I agree with you in principle, for now I have used up the time I
have available for messing with diagnostics, so I'm going to go ahead with
what we have for now. Spelling patches are of course welcome. :-)
Bill
>
> https://gcc.gnu.org/codingconventions.html#Spelling
>
> Martin
>