This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] [PR79542][Ada] Fix ICE in dwarf2out.c with nested func. inlining
- From: Jason Merrill <jason at redhat dot com>
- To: Pierre-Marie de Rodat <derodat at adacore dot com>
- Cc: gcc-patches List <gcc-patches at gcc dot gnu dot org>
- Date: Fri, 11 Aug 2017 14:29:51 -0700
- Subject: Re: [PATCH] [PR79542][Ada] Fix ICE in dwarf2out.c with nested func. inlining
- Authentication-results: sourceware.org; auth=none
- References: <20170314122410.21497-1-derodat@adacore.com> <CADzB+2=pi0de_o8tOzeQiayK9L8uMapHswTmhh=VZOOTTYL9mw@mail.gmail.com> <CADzB+2mWabNoaComYo8zdKKPvk85WAix79hZ=GpcQMxuA9Zz_Q@mail.gmail.com> <e27c3959-8c90-76e1-35c5-3831f3b586b1@adacore.com> <4506b40b-f2a4-5ed8-42d9-62902d9fb288@redhat.com> <dd86084d-99f0-b8be-e907-7e4b633016f9@adacore.com>
On Fri, Aug 11, 2017 at 6:05 AM, Pierre-Marie de Rodat
<derodat@adacore.com> wrote:
> On 08/07/2017 08:42 PM, Jason Merrill wrote:
>>
>> Perhaps the DECL_ABSTRACT_ORIGIN check in my patch should be
>> decl_ultimate_origin instead, which should return null in that case?
>
>
> It looks like it worked, thanks! Note that I had to tweak a bit your change
> in process_scope_vars to avoid a crash in a couple of Fortran tests (at -O3
> -g). Also, as the gcc_unreachable appears in an IF block, I turned it into a
> gcc_assert and remove the corresponding IF.
>
> Here is the final patch version, bootstrapped and regtested on x86_64-linux.
OK.
Jason