This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [C++ committed] Fix ICE with -Wshadow=compatible-local (PR c++/81640)
- From: Jason Merrill <jason at redhat dot com>
- To: Jakub Jelinek <jakub at redhat dot com>
- Cc: Nathan Sidwell <nathan at acm dot org>, gcc-patches List <gcc-patches at gcc dot gnu dot org>
- Date: Fri, 4 Aug 2017 12:50:36 -0400
- Subject: Re: [C++ committed] Fix ICE with -Wshadow=compatible-local (PR c++/81640)
- Authentication-results: sourceware.org; auth=none
- References: <20170802073801.GH2123@tucnak>
On Wed, Aug 2, 2017 at 3:38 AM, Jakub Jelinek <jakub@redhat.com> wrote:
> I've bootstrapped/regtested the following patch last night and committed
> after preapproval from Nathan, though of course a question is if
> lookup_fnfields_slot/lookup_fnfields_slot_nolazy shouldn't have
> if (!CLASS_TYPE_P (type)) return NULL_TREE; or
> gcc_assert (!CLASS_TYPE_P (type));
> readded to the beginning of those functions.
It seems that we already ICE if we call it with a non-class type, so
adding an assert would just document that behavior?
Jason