This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
[PR 81477] Set versionable regardless of optimization level
- From: Martin Jambor <mjambor at suse dot cz>
- To: GCC Patches <gcc-patches at gcc dot gnu dot org>
- Cc: Jan Hubicka <jh at suse dot cz>
- Date: Fri, 28 Jul 2017 14:26:11 +0200
- Subject: [PR 81477] Set versionable regardless of optimization level
- Authentication-results: sourceware.org; auth=none
Hi,
in revision 250048 the setting of cgraph's node versionable flag was
made conditional on optimization level, which is undesirable as there
may be other reasons to make a copy of a function, not just
optimization for example expansion to HSA which is what the PR 81477
is about.
Fixed thusly, the patch has passed bootstrap and testsuite on
x86_64-linux with HSA enabled and testing on an actual HSA-capable
machine. I'm still waiting for results of LTO-bootstrap and since the
change was pre-approved by Honza in person, I will commit it if passes
that as well.
Thanks,
Martin
2017-07-27 Martin Jambor <mjambor@suse.cz>
PR hsa/81477
* ipa-fnsummary.c (ipa_fn_summary_generate): Set versionable
regardless of optimization level.
---
gcc/ipa-fnsummary.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/gcc/ipa-fnsummary.c b/gcc/ipa-fnsummary.c
index 7324aac32c2..27e8d73f9df 100644
--- a/gcc/ipa-fnsummary.c
+++ b/gcc/ipa-fnsummary.c
@@ -3174,9 +3174,7 @@ ipa_fn_summary_generate (void)
FOR_EACH_DEFINED_FUNCTION (node)
if (DECL_STRUCT_FUNCTION (node->decl))
- node->local.versionable =
- (opt_for_fn (node->decl, optimize)
- && tree_versionable_function_p (node->decl));
+ node->local.versionable = tree_versionable_function_p (node->decl);
ipa_fn_summary_alloc ();
--
2.13.3