This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Set VALUE_EXPR after a debug stmt is generated (PR sanitizer/81340).
- From: Jakub Jelinek <jakub at redhat dot com>
- To: Martin Liška <mliska at suse dot cz>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Fri, 28 Jul 2017 13:19:21 +0200
- Subject: Re: [PATCH] Set VALUE_EXPR after a debug stmt is generated (PR sanitizer/81340).
- Authentication-results: sourceware.org; auth=none
- Authentication-results: ext-mx01.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
- Authentication-results: ext-mx01.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=jakub at redhat dot com
- Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com B7DA5E6FF1
- References: <da0c9072-3ba7-8a38-7206-4acc62d0482b@suse.cz>
- Reply-to: Jakub Jelinek <jakub at redhat dot com>
On Fri, Jul 28, 2017 at 01:11:51PM +0200, Martin Liška wrote:
> Hello.
>
> Following patch fixed race where we first need to properly build
> all gimple_build_debug_bind (arg, var, NULL) and then DECL_HAS_VALUE_EXPR_P
> can be registered.
>
> Patch can bootstrap on ppc64le-redhat-linux and survives regression tests.
>
> Ready to be installed?
> Martin
>
> gcc/ChangeLog:
>
> 2017-07-10 Martin Liska <mliska@suse.cz>
>
> PR sanitizer/81340
> * sanopt.c (sanitize_rewrite_addressable_params):
Missing description of what you've changed. Also, it isn't immediately
clear why this is needed. For force_gimple* etc. I'd understand that
setting DECL_VALUE_EXPR prematurely will result in gimplification of that
into the DECL_VALUE_EXPR, but gimple_build_assign or gimple_build_debug_bind
shouldn't do that. Or does the former invoke match.pd and that cares about
it?
Jakub