Re: [PATCH 1/2] Introduce testsuite support to run Python tests

[David Malcolm <dmalcolm at redhat dot com>]

On Wed, 2017-07-26 at 18:35 +0200, Pierre-Marie de Rodat wrote:
> On 07/26/2017 06:25 PM, David Malcolm wrote:
> > str.format was introduced in Python 2.6, so presumably the minimum
> > python 2 version here is at least 2.6+; for Python 3 I believe it
> > was
> > present in Python 3.0 onwards.
> 
> Hm… Python 2.6 is fairly old: last binary release was ages ago, last 
> source release was in 2013. Do you think it’s worth supporting it?

IIRC RHEL 6 has Python 2.6 as its /usr/bin/python (but Python 2.7 is
available as a "software collection" add-on).

I don't know if gcc as a project would want to support 2.6+ or simply
2.7 for Python 2.

> > > +def check(predicate, message):
> > > +    """
> > > +    If `predicate` is True, emit a PASS message, otherwise emit
> > > a
> > > FAIL one.
> > 
> > A very nitpicky nitpick: this comment should be spelled as "is
> > true"
> > (lowercase), rather than "is True" since the requirement is that
> > predicate's "truth value" is true, rather than predicate *is* the
> > boolean "True" singleton; e.g. if someone passes in an int as
> > predicate, its nonzero-ness would be used, rather than always being
> > false (since no int *is* the boolean singleton "True").
> 
> I agree with you: I updated the patch on my machine. Thank you!

Thanks.  I saw at least one other instance of this in the other patch;
I'll look over it again.

Dave