This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Fix libquadmath regression (bootstrap failure) on FreeBSD
- From: Jakub Jelinek <jakub at redhat dot com>
- To: Gerald Pfeifer <gerald at pfeifer dot com>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Wed, 19 Jul 2017 21:40:52 +0200
- Subject: Re: [PATCH] Fix libquadmath regression (bootstrap failure) on FreeBSD
- Authentication-results: sourceware.org; auth=none
- Authentication-results: ext-mx01.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
- Authentication-results: ext-mx01.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=jakub at redhat dot com
- Dkim-filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 8CA358123D
- Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 8CA358123D
- References: <alpine.LSU.2.21.1707192012420.5621@anthias.pfeifer.com>
- Reply-to: Jakub Jelinek <jakub at redhat dot com>
On Wed, Jul 19, 2017 at 09:35:36PM +0200, Gerald Pfeifer wrote:
> Hi Jakub,
>
> r250343 | jakub | 2017-07-19 13:12:58 +0000 (Wed, 19 Jul 2017) | 48 lines
>
> PR libquadmath/65757
> * quadmath-imp.h (math_opt_barrier, math_force_eval,
> math_narrow_eval, math_check_force_underflow,
> math_check_force_underflow_nonneg): Define.
> * math/ceilq.c: Backport changes from upstream glibc
> between 2012-11-01 and 2017-07-13.
>
> is causing this
>
> /scratch/tmp/gerald/GCC-HEAD/libquadmath/math/powq.c: In function 'powq':
> /scratch/tmp/gerald/GCC-HEAD/libquadmath/math/powq.c:266:11: error: 'u_int32_t'
> undeclared (first use in this function); did you mean 'uint32_t'?
> if (((((u_int32_t) hx >> 31) - 1) | (yisint - 1)) == 0)
> ^~~~~~~~~
> uint32_t
>
> on my "nightly" FreeBSD 10/i386 tester (and I could not find a mail
> on gcc-patches referring to this commit).
>
> This fixes it. Okay to apply to GCC?
Ok, thanks.
> And can you please push this
> to glibc as well (which I do not have access to)?
glibc uses u_int32_t in all the places of *powl.c where libquadmath
uses uint32_t, and various other files, so I guess it is intentional.
Jakub