This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: PATCH v2][Aarch64] Add vectorized mersenne twister
- From: Ulrich Drepper <drepper dot fsp at gmail dot com>
- To: Michael Collison <Michael dot Collison at arm dot com>
- Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>, nd <nd at arm dot com>
- Date: Tue, 18 Jul 2017 09:24:01 +0200
- Subject: Re: PATCH v2][Aarch64] Add vectorized mersenne twister
- Authentication-results: sourceware.org; auth=none
- References: <HE1PR0802MB23775781E0A58467C040B0F995A10@HE1PR0802MB2377.eurprd08.prod.outlook.com>
On Tue, Jul 18, 2017 at 7:57 AM, Michael Collison
<Michael.Collison@arm.com> wrote:
> This is the second version of a patch for Aarc64 to add a vectorized mersenne twister to libstdc++. The first version used intrinsics and included "arm_neon.h". After feedback from the community this version uses only GCC vector extensions and Aarch64 simd data types.
Looks OK. Just stylistically, why do you have
+#ifdef __ARM_NEON
+#ifdef __aarch64__
(in more than one place) instead of one preprocessor line?