Re: [DOC PATCH, i386] Fix PR 81294, _subborrow_u64 argument order inconsistent with intrinsic reference

[Uros Bizjak <ubizjak at gmail dot com>]

On Tue, Jul 4, 2017 at 10:51 PM, Jakub Jelinek <jakub@redhat.com> wrote:
> On Tue, Jul 04, 2017 at 10:41:26PM +0200, Uros Bizjak wrote:
>> Hello!
>>
>> Apparently, Intel changed operand order with the new intrinsic
>> reference release version. Attached patch updates gcc intrinsic
>> headers accordingly.
>>
>> 2017-07-04  Uros Bizjak  <ubizjak@gmail.com>
>>
>>     PR target/81294
>>     * config/i386/adxintrin.h (_subborrow_u32): Swap _X and _Y
>>     arguments in the call to __builtin_ia32_sbb_u32.
>>     (_subborrow_u64): Swap _X and _Y arguments in the call to
>>     __builtin_ia32_sbb_u64.
>>
>> testsuite/ChangeLog:
>>
>> 2017-07-04  Uros Bizjak  <ubizjak@gmail.com>
>>
>>     PR target/81249
>>     * gcc.target/i386/adx_addcarryx32-2.c (adx_test): Swap
>>     x and y arguments in the call to _subborrow_u32.
>>     * gcc.target/i386/adx_addcarryx64-2.c (adx_test): Swap
>>     x and y arguments in the call to _subborrow_u64.
>>     * gcc.target/i386/pr81294-1.c: New test.
>>     * gcc.target/i386/pr81294-2.c: Ditto.
>>
>> Bootstrapped and regression tested on x86_64-linux-gnu {,-m32}.
>>
>> Committed to mainline SVN, willbe backported to release branches.
>
> When it goes into release branches, it needs changes.html changes
> for each of those to make users aware of that.
> 7.2 will have rc after mid July, so if you want it in 7.2, it should be
> committed before that.  5.5 + 5.x branch closing will be around that time
> too.

IMO, we should change only gcc-7 release branch, so developers can
test for gcc-7.2+ to determine which release swapped arguments of
mentioned intrinsics.

The attached doc patch adds commented-out generic gcc-7.2 entry plus
the above target-specific change.

OK for branch?

Uros.

Attachment: d.diff.txt
Description: Text document