This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH-v3] [SPARC] Add a workaround for the LEON3FT store-store errata
- From: Daniel Cederman <cederman at gaisler dot com>
- To: Eric Botcazou <ebotcazou at adacore dot com>
- Cc: gcc-patches at gcc dot gnu dot org, sebastian dot huber at embedded-brains dot de, davem at davemloft dot net, daniel at gaisler dot com
- Date: Thu, 29 Jun 2017 17:15:43 +0200
- Subject: Re: [PATCH-v3] [SPARC] Add a workaround for the LEON3FT store-store errata
- Authentication-results: sourceware.org; auth=none
- References: <20170627085530.12596-1-cederman@gaisler.com> <9253669.0heIyC41JS@polaris>
Hello Eric,
Thank you for reviewing the patch.
Let's forget -mfix-gr712rc for now, -mfix-ut700 is enough I think.
I think it would be confusing to use the -mfix-ut700 flag when compiling
for the GR712RC. Now when we are not using a generic name for the errata
workaround we should at least have unique flags for the two major CPUs
that are afflicted by this errata.
I'm not thrilled with this, it's undocumented, the other workaround don't have
it and I don't think that we really need it.
The B2BST errata workaround requires more changes to assembler routines
commonly used by operating systems, such as for example register window
handling, than what the UT699 workaround needed. It would be nice to
have a way to only enable these modification when the -mfix- flag is
used. The alternative would be to provide a define directly on the
compiler command line in conjunction with -mfix flag. But if more
changes are required later on it would be good to have the define more
closely tied to the flag to minimize the number of changes to Makefiles
and etc.
Would it be OK to add if we document it properly?
--
Daniel Cederman
Cobham Gaisler