This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH, rs6000] builtins-3-vec_reve-runnable fix minimum platform
- From: Segher Boessenkool <segher at kernel dot crashing dot org>
- To: Carl Love <cel at us dot ibm dot com>
- Cc: gcc-patches at gcc dot gnu dot org, David Edelsohn <dje dot gcc at gmail dot com>, Bill Schmidt <wschmidt at linux dot vnet dot ibm dot com>
- Date: Wed, 28 Jun 2017 17:38:23 -0500
- Subject: Re: [PATCH, rs6000] builtins-3-vec_reve-runnable fix minimum platform
- Authentication-results: sourceware.org; auth=none
- References: <1498672672.7044.11.camel@us.ibm.com>
Hi Carl,
On Wed, Jun 28, 2017 at 10:57:52AM -0700, Carl Love wrote:
> The vec_reve builtin test builtins-3-vec_reve-runnable did not have a
> minimum Power processor specified. The thought was the instructions for
> the builtin were available on all the older processors. Unfortunately,
> it turns out the builtin does require vsx hardware (-mvsx option). Bill
> Schmidt said that the minimum platform that the builtins need to be
> supported on is Power 7. The following patch sets the minimum platform
> as Power 7.
>
> Please let me know if the following patch is acceptable. Thanks.
Sure, that works. Or just skip the testcase then (but we don't yet
have a convenient way to do that). Okay for trunk (nit below).
> 2017-06-28 Carl Love <cel@us.ibm.com>
>
> * gcc.target/powerpc/builtins-3-vec_reve-runnable.c (dg-options,
> dg-skip-if): add mcpu=power7
Start with a capital, end with a dot. The dg-skip-if is new... Maybe
just lazily write
* gcc.target/powerpc/builtins-3-vec_reve-runnable.c: Use -mvsx
-mcpu=power7.
:-)
Thanks,
Segher