This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH, GCC/testsuite/ARM] Consistently check for neon in vect effective targets




On 28/06/17 15:59, Kyrill Tkachov wrote:
Hi Thomas,

On 28/06/17 15:49, Thomas Preudhomme wrote:
On 20/06/17 13:44, Christophe Lyon wrote:


The results with a more recent trunk (r249356)) are here:
http://people.linaro.org/~christophe.lyon/cross-validation/gcc-test-patches/249356-consistent_neon_check.patch/report-build-info.html

They are slightly different, but still tedious to check ;-)

I've checked arm-none-linux-gnueabi and arm-none-linux-gnueabihf and found that:

* there's no new FAIL
* changes to UNSUPPORTED and NA are for the same files
* changes are only for tests in a vect directory
* changes for arm-none-linux-gnueabihf are only when targeting vfp without neon (tests are disabled because there is no vector unit)

Changes to arm-none-linux-gnueabi makes sense since this defaults to soft floating point and none of the test disabled adds any option to select another variant.

I believe this all makes sense.

Therefore, is this ok to commit?

Best regards,

Thomas

@@ -4987,10 +4982,10 @@ proc check_effective_target_vect_shift_char { } {

  proc check_effective_target_vect_long { } {
      if { [istarget i?86-*-*] || [istarget x86_64-*-*]
-     || (([istarget powerpc*-*-*]
-              && ![istarget powerpc-*-linux*paired*])
+     || (([istarget powerpc*-*-*]
+              && ![istarget powerpc-*-linux*paired*])
                && [check_effective_target_ilp32])


Is this just a whitespace change?
If it is intended then okay.

It is yes, trailing whitespace. I took the liberty to fix it because I was changing some other issues in the same procedure.


This is okay with a ChangeLog entry.

Sorry, I should have pasted it again from the initial message.

2017-06-06  Thomas Preud'homme  <thomas.preudhomme@arm.com>

	* lib/target-supports.exp (check_effective_target_vect_int): Replace
	current ARM check by ARM NEON's availability check.
	(check_effective_target_vect_intfloat_cvt): Likewise.
	(check_effective_target_vect_uintfloat_cvt): Likewise.
	(check_effective_target_vect_floatint_cvt): Likewise.
	(check_effective_target_vect_floatuint_cvt): Likewise.
	(check_effective_target_vect_shift): Likewise.
	(check_effective_target_whole_vector_shift): Likewise.
	(check_effective_target_vect_bswap): Likewise.
	(check_effective_target_vect_shift_char): Likewise.
	(check_effective_target_vect_long): Likewise.
	(check_effective_target_vect_float): Likewise.
	(check_effective_target_vect_perm): Likewise.
	(check_effective_target_vect_perm_byte): Likewise.
	(check_effective_target_vect_perm_short): Likewise.
	(check_effective_target_vect_widen_sum_hi_to_si_pattern): Likewise.
	(check_effective_target_vect_widen_sum_qi_to_hi): Likewise.
	(check_effective_target_vect_widen_mult_qi_to_hi): Likewise.
	(check_effective_target_vect_widen_mult_hi_to_si): Likewise.
	(check_effective_target_vect_widen_mult_qi_to_hi_pattern): Likewise.
	(check_effective_target_vect_widen_mult_hi_to_si_pattern): Likewise.
	(check_effective_target_vect_widen_shift): Likewise.
	(check_effective_target_vect_extract_even_odd): Likewise.
	(check_effective_target_vect_interleave): Likewise.
	(check_effective_target_vect_multiple_sizes): Likewise.
	(check_effective_target_vect64): Likewise.
	(check_effective_target_vect_max_reduc): Likewise.


Thanks, this looks like a good change.
Kyrill

Thanks!

Best regards,

Thomas


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]