This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [Patch testsuite]


On Jun 26, 2017, at 11:35 AM, Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE> wrote:
> 
> Mike Stump <mikestump@comcast.net> writes:
> 
>> On Jun 26, 2017, at 2:34 AM, Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE> wrote:
>>> 
>>>> Is it OK to commit the following patch (darwin only)?
>>> 
>>> this patch needs a ChangeLog entry (and preferably a description of the
>>> problem you're fixing ;-)
>> 
>> Actually, the CL isn't required, testsuite is special that way.
> 
> I believe it is,

That's way I sent the email.  It's been this way for a very long time.  I don't recall participating in a consensus building exercise where we changed the requirement, maybe I was sleeping?  If you have a pointer to a thread where we changed it, that'd be fine.  I'm happy to update my notion if we changed it.  The doc page says:

  There is no established convention on when ChangeLog entries are to be made for testsuite changes

so, certainly no one reflected any such change in the web pages yet.  I'd rather consensus build rather than you or I just passing an edict.  Last time we spoke about ChangeLogs, the direction was to eliminate them entirely in preference to the git checkin comments, so, not sure we'd go in that direction today.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]