This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [Patch testsuite]


Hi Dominique,

> Is it OK to commit the following patch (darwin only)?

this patch needs a ChangeLog entry (and preferably a description of the
problem you're fixing ;-)

> --- ../_clean/gcc/testsuite/gcc.dg/pubtypes-2.c 2017-06-17
> 17:55:51.000000000 +0200
> +++ gcc/testsuite/gcc.dg/pubtypes-2.c	2017-06-25 18:01:52.000000000 +0200
> @@ -2,7 +2,7 @@
>  /* { dg-options "-O0 -gdwarf-2 -dA" } */
>  /* { dg-skip-if "Unmatchable assembly" { mmix-*-* } } */
>  /* { dg-final { scan-assembler "__debug_pubtypes" } } */
> -/* { dg-final { scan-assembler "long+\[ \t\]+0x13b+\[ \t\]+\[#;]+\[
> \t\]+Pub Info Length" } } */
> +/* { dg-final { scan-assembler "long+\[ \t\]+0x125\[ \t\]+\[#;]+\[
> \t\]+Pub Info Length" } } */
>  /* { dg-final { scan-assembler "used_struct\\\\0\"+\[ \t\]+\[#;]+\[
> \t\]+external name" } } */
>  /* { dg-final { scan-assembler-not "unused_struct\\\\0\"+\[ \t\]+\[#;]+\[
> \t\]+external name" } } */
>  
> --- ../_clean/gcc/testsuite/gcc.dg/pubtypes-3.c 2017-06-17
> 17:55:52.000000000 +0200
> +++ gcc/testsuite/gcc.dg/pubtypes-3.c	2017-06-25 18:03:38.000000000 +0200
> @@ -2,7 +2,7 @@
>  /* { dg-options "-O0 -gdwarf-2 -dA" } */
>  /* { dg-skip-if "Unmatchable assembly" { mmix-*-* } } */
>  /* { dg-final { scan-assembler "__debug_pubtypes" } } */
> -/* { dg-final { scan-assembler "long+\[ \t\]+0x13b+\[ \t\]+\[#;]+\[
> \t\]+Pub Info Length" } } */
> +/* { dg-final { scan-assembler "long+\[ \t\]+0x125\[ \t\]+\[#;]+\[
> \t\]+Pub Info Length" } } */
>  /* { dg-final { scan-assembler "used_struct\\\\0\"+\[ \t\]+\[#;]+\[
> \t\]+external name" } } */
>  /* { dg-final { scan-assembler-not "unused_struct\\\\0\"+\[ \t\]+\[#;]+\[
> \t\]+external name" } } */
>  /* { dg-final { scan-assembler-not "\"list_name_type\\\\0\"+\[
> \t\]+\[#;]+\[ \t\]+external name" } } */
> --- ../_clean/gcc/testsuite/gcc.dg/pubtypes-4.c 2017-06-17
> 17:55:51.000000000 +0200
> +++ gcc/testsuite/gcc.dg/pubtypes-4.c	2017-06-25 18:04:38.000000000 +0200
> @@ -2,7 +2,7 @@
>  /* { dg-options "-O0 -gdwarf-2 -dA" } */
>  /* { dg-skip-if "Unmatchable assembly" { mmix-*-* } } */
>  /* { dg-final { scan-assembler "__debug_pubtypes" } } */
> -/* { dg-final { scan-assembler "long+\[ \t\]+0x172+\[ \t\]+\[#;]+\[
> \t\]+Pub Info Length" } } */
> +/* { dg-final { scan-assembler "long+\[ \t\]+0x15c\[ \t\]+\[#;]+\[
> \t\]+Pub Info Length" } } */
>  /* { dg-final { scan-assembler "used_struct\\\\0\"+\[ \t\]+\[#;]+\[
> \t\]+external name" } } */
>  /* { dg-final { scan-assembler-not "unused_struct\\\\0\"+\[ \t\]+\[#;]+\[
> \t\]+external name" } } */
>  /* { dg-final { scan-assembler "\"list_name_type\\\\0\"+\[ \t\]+\[#;]+\[
> \t\]+external name" } } */

Why not got for

/* { dg-final { scan-assembler "long+\[ \t\]+0x\[0-9a-f]+\[ \t\]+\[#;]+\[ \t\]+P
ub Info Length" } } */

i.e. not checking for a specific length, as gcc.dg/pubtypes-1.c already
does?

Thanks.
        Rainer

-- 
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]