This is the mail archive of the
mailing list for the GCC project.
Re: [PATCH] reorganize block/string move/compare expansions out of rs6000.c
- From: Segher Boessenkool <segher at kernel dot crashing dot org>
- To: Aaron Sawdey <acsawdey at linux dot vnet dot ibm dot com>
- Cc: gcc-patches at gcc dot gnu dot org, David Edelsohn <dje dot gcc at gmail dot com>, Bill Schmidt <wschmidt at linux dot vnet dot ibm dot com>
- Date: Fri, 23 Jun 2017 11:45:23 -0500
- Subject: Re: [PATCH] reorganize block/string move/compare expansions out of rs6000.c
- Authentication-results: sourceware.org; auth=none
- References: <email@example.com>
On Thu, Jun 22, 2017 at 04:01:54PM -0500, Aaron Sawdey wrote:
> This patch moves about 1400 lines of code for various block and string
> compare/move/zero expansions out of rs6000.c into a new file
> rs6000-string.c. Segher had asked me to do this before I go adding new
> code here.
> Bootstrap passes on ppc64le, regtest in progress. OK for trunk if that
> 2017-06-22 Aaron Sawdey <firstname.lastname@example.org>
> * config/rs6000/rs6000-string.c (expand_block_clear,
> do_load_for_compare, select_block_compare_mode,
> compute_current_alignment, expand_block_compare,
> expand_strncmp_align_check, expand_strn_compare,
> expand_block_move, rs6000_output_load_multiple)
> Move functions related to string/block move/compare
> to a separate file.
> * config/rs6000/rs6000.c Move above functions to rs6000-string.c.
> * config/rs6000/rs6000-protos.h (rs6000_emit_dot_insn) Add prototype
> for this function which is now used in two files.
> * config/rs6000/t-rs6000 Add rule to compile rs6000-string.o.
> * config.gcc Add rs6000-string.o to extra_objs for
> targets powerpc*-*-* and rs6000*-*-*.
You're missing colons everywhere here.
> +/* Subroutines used for code generation on IBM RS/6000.
Please make this more specific.
> + Copyright (C) 1991-2017 Free Software Foundation, Inc.
> + Contributed by Richard Kenner (email@example.com)
I don't think Richard wrote anything in this new file?
> +#define min(A,B) ((A) < (B) ? (A) : (B))
> +#define max(A,B) ((A) > (B) ? (A) : (B))
There are MIN and MAX in system.h already... min is used only once, max
is used never; change it to use MIN?
Okay for trunk with those things taken care of. Thanks!