This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: libgo patch committed: Fix ptrace implementation on MIPS


James, any thoughts?

Ian

On Thu, Jun 22, 2017 at 12:55 AM, Andreas Schwab <schwab@suse.de> wrote:
> On Jun 21 2017, Ian Lance Taylor <iant@golang.org> wrote:
>
>> Index: libgo/sysinfo.c
>> ===================================================================
>> --- libgo/sysinfo.c   (revision 249205)
>> +++ libgo/sysinfo.c   (working copy)
>> @@ -102,6 +102,9 @@
>>  #if defined(HAVE_LINUX_NETLINK_H)
>>  #include <linux/netlink.h>
>>  #endif
>> +#if defined(HAVE_LINUX_PTRACE_H)
>> +#include <linux/ptrace.h>
>> +#endif
>>  #if defined(HAVE_LINUX_RTNETLINK_H)
>>  #include <linux/rtnetlink.h>
>>  #endif
>
> That breaks ia64:
>
> In file included from /usr/include/asm/ptrace.h:58:0,
>                  from /usr/include/linux/ptrace.h:69,
>                  from ../../../libgo/sysinfo.c:106:
> /usr/include/asm/fpu.h:57:8: error: redefinition of 'struct ia64_fpreg'
>  struct ia64_fpreg {
>         ^~~~~~~~~~
> In file included from /usr/include/signal.h:339:0,
>                  from /usr/local/gcc/gcc-20170622/Build/gcc/include-fixed/sys/ucontext.h:32,
>                  from /usr/include/ucontext.h:27,
>                  from ../../../libgo/sysinfo.c:17:
> /usr/include/bits/sigcontext.h:32:8: note: originally defined here
>  struct ia64_fpreg
>         ^~~~~~~~~~
> In file included from /usr/include/linux/ptrace.h:69:0,
>                  from ../../../libgo/sysinfo.c:106:
> /usr/include/asm/ptrace.h:208:8: error: redefinition of 'struct pt_all_user_regs'
>  struct pt_all_user_regs {
>         ^~~~~~~~~~~~~~~~
> In file included from ../../../libgo/sysinfo.c:66:0:
> /usr/include/sys/ptrace.h:116:8: note: originally defined here
>  struct pt_all_user_regs
>         ^~~~~~~~~~~~~~~~
>
> Andreas.
>
> --
> Andreas Schwab, SUSE Labs, schwab@suse.de
> GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE  1748 E4D4 88E3 0EEA B9D7
> "And now for something completely different."


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]