This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Refactor fileptr_type_node handling


On Thu, Jun 22, 2017 at 10:46 AM, Marc Glisse <marc.glisse@inria.fr> wrote:
> Hello,
>
> I was asked to handle (const) fenv_t and fexcept_t the same way as FILE and
> const tm. Since these have special handling in quite a few places, it seems
> necessary to make their support a bit more generic first. If I didn't mess
> up, this patch should not change anything.

It looks like a good thing to do before extending the set of types
handled this way.

The only thing I dislike is the name 'predeclared', isn't it actually
forward declared or simply declared (as opposed to defined)?
So - declared_ptr_types maybe?

Sorry for bikeshedding... - the patch itself looks good to me.

Thanks,
Richard.

> Bootstrap + testsuite on powerpc64le-unknown-linux-gnu.
>
> 2017-06-22  Marc Glisse  <marc.glisse@inria.fr>
>
> gcc/
>         * tree.h (predeclared_type): New type.
>         (predeclared_types): Declare new array.
>         * tree.c (predeclared_types): New array.
>         (free_lang_data, build_common_tree_nodes): Use it.
>
> gcc/c-family/
>         * c-common.c (c_common_nodes_and_builtins): Use predeclared_types.
>
> gcc/cp/
>         * decl.c (duplicate_decls): Use predeclared_types.
>
> gcc/lto/
>         * lto-lang.c (lto_init): Use predeclared_types.
>
> --
> Marc Glisse


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]