This is the mail archive of the
mailing list for the GCC project.
Re: Refactor fileptr_type_node handling
- From: Richard Biener <richard dot guenther at gmail dot com>
- To: Marc Glisse <marc dot glisse at inria dot fr>
- Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>
- Date: Thu, 22 Jun 2017 12:47:23 +0200
- Subject: Re: Refactor fileptr_type_node handling
- Authentication-results: sourceware.org; auth=none
- References: <alpine.DEB.firstname.lastname@example.org>
On Thu, Jun 22, 2017 at 10:46 AM, Marc Glisse <email@example.com> wrote:
> I was asked to handle (const) fenv_t and fexcept_t the same way as FILE and
> const tm. Since these have special handling in quite a few places, it seems
> necessary to make their support a bit more generic first. If I didn't mess
> up, this patch should not change anything.
It looks like a good thing to do before extending the set of types
handled this way.
The only thing I dislike is the name 'predeclared', isn't it actually
forward declared or simply declared (as opposed to defined)?
So - declared_ptr_types maybe?
Sorry for bikeshedding... - the patch itself looks good to me.
> Bootstrap + testsuite on powerpc64le-unknown-linux-gnu.
> 2017-06-22 Marc Glisse <firstname.lastname@example.org>
> * tree.h (predeclared_type): New type.
> (predeclared_types): Declare new array.
> * tree.c (predeclared_types): New array.
> (free_lang_data, build_common_tree_nodes): Use it.
> * c-common.c (c_common_nodes_and_builtins): Use predeclared_types.
> * decl.c (duplicate_decls): Use predeclared_types.
> * lto-lang.c (lto_init): Use predeclared_types.
> Marc Glisse