This is the mail archive of the mailing list for the GCC project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

RE: [PATCH] [i386] Enable Control-flow Enforcement Technology (CET).

Thanks for the feedback. I'll redo the patch according to your comments.


-----Original Message-----
From: Joseph Myers [] 
Sent: Tuesday, June 20, 2017 11:30 PM
To: Tsimbalist, Igor V <>
Cc:; Chupin, Pavel V <>
Subject: Re: [PATCH] [i386] Enable Control-flow Enforcement Technology (CET).
Importance: High

This patch is completely missing documentation (in *.texi files) of the new options, attribute, built-in functions etc.

You appear to be adding quite target-specific things to the architecture-independent compiler.  If the attribute, for example, is to be architecture-independent, the documentation needs to define semantics for it that make sense on any architecture (or any architecture providing such features), not just on x86; the patch submission needs to justify the design choices of what is target-specific and what is target-independent.  
(Cf. MPX where there are various architecture-independent features for which a software implementation would be logically possible, although actually the only implementation of those features in GCC is for MPX
hardware.)  I don't think this patch would even build for non-x86 targets, because you're putting completely x86-specific references such as TARGET_CET and gen_nop_endbr in target-independent files.

Joseph S. Myers

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]