This is the mail archive of the
mailing list for the GCC project.
Re: [PATCH] [i386] Enable Control-flow Enforcement Technology (CET).
- From: Joseph Myers <joseph at codesourcery dot com>
- To: "Tsimbalist, Igor V" <igor dot v dot tsimbalist at intel dot com>
- Cc: "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>, "Chupin, Pavel V" <pavel dot v dot chupin at intel dot com>
- Date: Tue, 20 Jun 2017 21:29:44 +0000
- Subject: Re: [PATCH] [i386] Enable Control-flow Enforcement Technology (CET).
- Authentication-results: sourceware.org; auth=none
- References: <D511F25789BA7F4EBA64C8A63891A0027A9EA880@IRSMSX102.ger.corp.intel.com>
This patch is completely missing documentation (in *.texi files) of the
new options, attribute, built-in functions etc.
You appear to be adding quite target-specific things to the
architecture-independent compiler. If the attribute, for example, is to
be architecture-independent, the documentation needs to define semantics
for it that make sense on any architecture (or any architecture providing
such features), not just on x86; the patch submission needs to justify the
design choices of what is target-specific and what is target-independent.
(Cf. MPX where there are various architecture-independent features for
which a software implementation would be logically possible, although
actually the only implementation of those features in GCC is for MPX
hardware.) I don't think this patch would even build for non-x86 targets,
because you're putting completely x86-specific references such as
TARGET_CET and gen_nop_endbr in target-independent files.
Joseph S. Myers