This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH GCC][06/13]Preserve loop nest in whole distribution life time
On Mon, Jun 19, 2017 at 3:32 PM, Bin.Cheng <amker.cheng@gmail.com> wrote:
> On Tue, Jun 13, 2017 at 12:08 PM, Richard Biener
> <richard.guenther@gmail.com> wrote:
>> On Tue, Jun 13, 2017 at 1:06 PM, Richard Biener
>> <richard.guenther@gmail.com> wrote:
>>> On Mon, Jun 12, 2017 at 7:02 PM, Bin Cheng <Bin.Cheng@arm.com> wrote:
>>>> Hi,
>>>> This simple patch computes and preserves loop nest vector for whole distribution
>>>> life time. The loop nest will be used multiple times in on-demand data dependence
>>>> computation.
>>>>
>>>> Bootstrap and test on x86_64 and AArch64. Is it OK?
>>>
>>> Don't like it too much but I guess we can see if refactoring it back
>>> to pass down
>>> loop_nest can work.
>>>
>>> Ok.
>>
>> Oh.
>>
>> +/* The loop (nest) to be distributed. */
>> +static vec<loop_p> *loop_nest;
>> +
>>
>> please make it
>>
>> static vec<loop_p> loop_nest;
>>
>> instead to avoid a pointless indirection (vec<> just contains a
>> pointer to allocated storage).
> Hi Richard,
> This is the updated patch according to your comment, is it OK?
Ok.
Richard.
> Thanks,
> bin
>
> 2017-06-17 Bin Cheng <bin.cheng@arm.com>
>
> * tree-loop-distribution.c (loop_nest): New global var.
> (build_rdg): Use loop directly, rather than loop nest.
> (pg_add_dependence_edges): Remove loop nest parameter. Use global
> variable directly.
> (distribute_loop): Compute global variable loop nest. Update use.