This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH, rs6000] (v3) Fold vector shifts in GIMPLE


Hi Will,

On Tue, Jun 13, 2017 at 02:44:45PM -0500, Will Schmidt wrote:
> I sniff-tested the latest changes on Power8, with good results.  Full
> regtest running.  OK for trunk?

This looks good to me, if Richard is happy with it now.  Some very minor
things and it is good to go:

> 	2017-06-13  Will Schmidt  <will_schmidt@vnet.ibm.com>
> 
> 	* config/rs6000/rs6000.c: Add include of ssa-propagate.h for
> 	update_call_from_tree().
> 	(rs6000_gimple_fold_builtin): Add handling
> 	for early expansion of vector shifts (sl,sr,sra,rl).

Funny line break there.

> +  /* Flavors of vector shift right algebraic.
> +   * vec_sra{b,h,w} -> vsra{b,h,w}.  */

No leading * in comments please (more of those below).

> +	/* convert arg0 to unsigned.  */

Full sentences are capitalized.


Segher


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]