This is the mail archive of the
mailing list for the GCC project.
Re: [PATCH,AIX] Enable libiberty to read AIX XCOFF
- From: DJ Delorie <dj at redhat dot com>
- To: David Edelsohn <dje dot gcc at gmail dot com>
- Cc: tony dot reix at atos dot net, iant at golang dot org, matthieu dot sarter dot external at atos dot net, gcc-patches at gcc dot gnu dot org
- Date: Tue, 06 Jun 2017 19:52:22 -0400
- Subject: Re: [PATCH,AIX] Enable libiberty to read AIX XCOFF
- Authentication-results: sourceware.org; auth=none
- Authentication-results: ext-mx08.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
- Authentication-results: ext-mx08.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=dj at redhat dot com
- Dkim-filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 78A5EC0587D3
- Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 78A5EC0587D3
David Edelsohn <email@example.com> writes:
> This patch generally looks good to me -- it clearly is an incremental
> improvement. One of the libiberty maintainers, such as Ian, needs to
> approve the patch.
As AIX maintainer, I think you have the authority to approve patches
like this, which only affect your OS. I see no reason to reject the
patch myself, other than:
+ symtab = XNEWVEC (struct external_syment, ocr->nsyms * SYMESZ);
+ if (!simple_object_internal_read (sobj->descriptor,
There's no check to see if XNEWVEC succeeded.
Also, the use of XDELETEVEC is inconsistently protected with a "if (foo
!= NULL)" throughout, but passing NULL to XDELETEVEC (essentially,
free()) is allowed anyway, so this is only a stylistic issue, which I'm
not particularly worried about.