This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PING] [PING] Make the OpenACC C++ acc_on_device wrapper "always inline"


On Tue, Jun 06, 2017 at 08:35:40AM +0200, Thomas Schwinge wrote:
> > > commit 9cc3a384c17e9f692f7864c604d2e2f9fbf0bac9
> > > Author: Thomas Schwinge <thomas@codesourcery.com>
> > > Date:   Tue May 23 13:21:14 2017 +0200
> > > 
> > >     Make the OpenACC C++ acc_on_device wrapper "always inline"
> > >     
> > >             libgomp/
> > >             * openacc.h [__cplusplus] (acc_on_device): Mark as "always
> > >             inline".
> > >             * testsuite/libgomp.oacc-c-c++-common/acc-on-device-2.c: Remove
> > >             file; test cases already present...
> > >             * testsuite/libgomp.oacc-c-c++-common/acc_on_device-1.c: ... in
> > >             this file.  Update.
> > >             * testsuite/libgomp.oacc-c-c++-common/acc-on-device.c: Remove
> > >             file; test cases now present...
> > >             * testsuite/libgomp.oacc-c-c++-common/acc_on_device-2.c: ... in
> > >             this new file.
> > >             * testsuite/libgomp.oacc-c-c++-common/parallel-dims.c: Update.

I don't like this very much.
Can't you instead just turn the builtin into BT_FN_INT_VAR and diagnose
during folding if it has no or 2+ arguments or if the argument is not type
compatible with int?

	Jakub


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]