This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH, GCC/ARM] Rename *_compute_save_reg_mask ()



On 26/05/17 15:19, Thomas Preudhomme wrote:
Hi,

Name of arm_compute_save_reg_mask and thumb1_compute_save_reg_mask
suggest that all register saving computation is done in these function
but these only deal with core registers. The caller
arm_compute_frame_layout () also computes some of the register saving,
eg. for VFP registers in 32bit targets. This commit rename former
functions to refer to core registers saving.

ChangeLog entry is as follows:

*** gcc/ChangeLog ***

2017-05-24  Thomas Preud'homme  <thomas.preudhomme@arm.com>

    * config/arm/arm.c (arm_compute_save_reg_mask): Rename into ...
    (arm_compute_save_core_reg_mask): This.
    (thumb1_compute_save_reg_mask): Rename into ...
    (thumb1_compute_save_core_reg_mask): This.
    (arm_compute_save_reg0_reg12_mask): Adapt comment.
    (arm_compute_frame_layout): Likewise.

Ok for trunk?

Tested with a successful arm-none-eabi build.


Ok if a arm-none-linux-gnueabihf shows no problems.
This looks simple enough to me and a useful renaming.

Kyrill

Best regards,

Thomas


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]