This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Add attribute((target_clone(...))) to PowerPC


On Fri, Jun 02, 2017 at 11:55:57AM -0500, Segher Boessenkool wrote:
> Hi!
> 
> On Fri, Jun 02, 2017 at 10:16:27AM -0400, Michael Meissner wrote:
> > > With "you don't have to give the enum a name" I meant write it as
> > > 
> > > enum {
> > >   CLONE_DEFAULT = 0,
> > >   CLONE_ISA_2_05,
> > > [...]
> > >   CLONE_MASK
> > > };
> > > 
> > > If you do "const int", I think it should be "static const int"?
> > 
> > Ok.  I think I was under the impression that enums were more tightly typed on
> > C++ compared to C, and that you needed explicit casts to/from integer.
> 
> No, conversions from enum to int are still explicitly allowed (but not
> the other way around indeed).
> 
> > > > +#if defined (ASM_OUTPUT_TYPE_DIRECTIVE)
> > > > +  if (targetm.has_ifunc_p ())
> > > 
> > > Hrm, I still don't see what you need the #ifdef for.  What in the
> > > following code won't compile without it?  Or does targetm.has_ifunc_p
> > > return the wrong answer?
> > 
> > Right now, we only enable ifunc by default under Linux, so I removed the
> > #ifdef.  We will see if it breaks on non Linux systems.
> 
> Heh, you could test, you know ;-)

I actually did a bootstrap/make check of everything but the removal of the
#ifdef.  There was one test that had failed with my previous base run that now
runs, but it looks like a filesystem problem with the old base run.

> The patch is okay for trunk, but please test on AIX.

You mentioned in private IRC that you would do the run on AIX, did you want me
to wait until it is finished?

-- 
Michael Meissner, IBM
IBM, M/S 2506R, 550 King Street, Littleton, MA 01460-6245, USA
email: meissner@linux.vnet.ibm.com, phone: +1 (978) 899-4797


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]