This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Optimisation of std::binary_search of the <algorithm> header
- From: Tim Song <t dot canens dot cpp at gmail dot com>
- To: jay pokarna <jay dot pokarna10 at gmail dot com>
- Cc: gcc-patches <gcc-patches at gcc dot gnu dot org>, "libstdc++" <libstdc++ at gcc dot gnu dot org>
- Date: Mon, 29 May 2017 01:14:19 -0400
- Subject: Re: Optimisation of std::binary_search of the <algorithm> header
- Authentication-results: sourceware.org; auth=none
- References: <CAK61LuBFcZnuCM9rfK2_xxOg-cWZVfsKz-1h2Uj4GN2OC4TU0Q@mail.gmail.com>
This is not a patch. Nor is it an implementation of
std::binary_search, which is a function template that accepts
arbitrary forward iterators and optionally arbitrary comparator
objects, rather than just pointers.
If you want to find someone to review your code, consider something
like https://codereview.stackexchange.com/.
While I'm not a maintainer, I strongly suspect that for something like
this to have a chance of getting into libstdc++, it needs to, at the
very minimum, implement the standard signature and be accompanied by
sufficient performance benchmarks showing that it is better performing
than the existing implementation.