This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Match x86 family machine constraints section with constarints.md
- From: Uros Bizjak <ubizjak at gmail dot com>
- To: Sandra Loosemore <sandra at codesourcery dot com>
- Cc: "Peryt, Sebastian" <sebastian dot peryt at intel dot com>, "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>, "Koval, Julia" <julia dot koval at intel dot com>, "kirill dot yukhin at gmail dot com" <kirill dot yukhin at gmail dot com>
- Date: Wed, 24 May 2017 15:30:43 +0200
- Subject: Re: [PATCH] Match x86 family machine constraints section with constarints.md
- Authentication-results: sourceware.org; auth=none
- References: <17623B198193D741876BD81A6E3AE5AD3BBAF0D4@irsmsx105.ger.corp.intel.com> <590251D7.60009@codesourcery.com> <17623B198193D741876BD81A6E3AE5AD3BBAF50A@irsmsx105.ger.corp.intel.com> <59245666.1070802@codesourcery.com>
On Tue, May 23, 2017 at 5:33 PM, Sandra Loosemore
<sandra@codesourcery.com> wrote:
> On 04/28/2017 03:30 AM, Peryt, Sebastian wrote:
>>
>> Hi,
>>
>> Thank you for your comments. I edited my patch accordingly. As for some of
>> your doubts:
>> - REX is the opcode prefix to access 64-bit register extensions
>> introduced in IA-32e mode.
>> - EVEX is the encoding prefix which applies to SIMD operating instructions
>> operating on XMM, YMM and ZMM registers. It was introduced with AVX-512
>> instructions.
>> - "number factor of four" that means that sources start in a multiple of 4
>> boundary. This is used for some of instructions.
>>
>> Also I'd like to add that this whole patch is strictly based on docstring
>> parts of constraints that are present in config/i386/constraints.md but not
>> in documentation (md.texi file). There is no new (new as in nonexistent in
>> code) content.
>>
>> I'm also adding Kirill Yukhin to CC, because I believe he is the correct
>> person that can catch any technical errors if any has slipped-in.
>
>
> The grammar/markup/etc are OK now, but I can't comment on technical
> correctness of the information.
LGTM.
Thanks,
Uros.