Re: [PATCH 12/12] [i386,testsuite] Test program for ms to sysv abi function calls.

[Thomas Preudhomme <thomas dot preudhomme at foss dot arm dot com>]

Hi Daniel,

On 27/04/17 09:09, Daniel Santos wrote:
> A comprehensive program for testing x86_64 ms_abi functions that call
> sysv_abi functions to help validate -mcall-ms2sysv-xlogues and use of
> aligned SSE MOVs after a (non-DRAP) realigned stack.
>
> Signed-off-by: Daniel Santos <daniel.santos@pobox.com>
> ---
>  gcc/Makefile.in                                    |   2 +
>  .../gcc.target/x86_64/abi/ms-sysv/do-test.S        | 163 +++++
>  gcc/testsuite/gcc.target/x86_64/abi/ms-sysv/gen.cc | 807 +++++++++++++++++++++
>  .../gcc.target/x86_64/abi/ms-sysv/ms-sysv.c        | 373 ++++++++++
>  .../gcc.target/x86_64/abi/ms-sysv/ms-sysv.exp      | 178 +++++
>  5 files changed, 1523 insertions(+)
>  create mode 100644 gcc/testsuite/gcc.target/x86_64/abi/ms-sysv/do-test.S
>  create mode 100644 gcc/testsuite/gcc.target/x86_64/abi/ms-sysv/gen.cc
>  create mode 100644 gcc/testsuite/gcc.target/x86_64/abi/ms-sysv/ms-sysv.c
>  create mode 100644 gcc/testsuite/gcc.target/x86_64/abi/ms-sysv/ms-sysv.exp

[SNIP]

> diff --git a/gcc/testsuite/gcc.target/x86_64/abi/ms-sysv/ms-sysv.exp b/gcc/testsuite/gcc.target/x86_64/abi/ms-sysv/ms-sysv.exp
> new file mode 100644
> index 00000000000..e317af9bd85
> --- /dev/null
> +++ b/gcc/testsuite/gcc.target/x86_64/abi/ms-sysv/ms-sysv.exp
> @@ -0,0 +1,178 @@

[SNIP]

> +
> +# Exit immediately if this isn't a native x86_64 target.
> +if { (![istarget x86_64-*-*] && ![istarget i?86-*-*])
> +     || ![is-effective-target lp64] || ![isnative] } then {
> +    unsupported "$subdir"
> +    return
> +}

This reports these tests as UNSUPPORTED for non x86_64 target rather than just 
not showing these tests. The usual pattern from what I could see is to just 
return (see gcc.target/arm/acle.exp)

Best regards,

Thomas