This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [Patch, Fortran, OOP] PR 79311: ICE in generate_finalization_wrapper, at fortran/class.c:1992
- From: Janus Weil <janus at gcc dot gnu dot org>
- To: Jerry DeLisle <jvdelisle at charter dot net>
- Cc: gfortran <fortran at gcc dot gnu dot org>, gcc-patches <gcc-patches at gcc dot gnu dot org>
- Date: Tue, 9 May 2017 22:59:21 +0200
- Subject: Re: [Patch, Fortran, OOP] PR 79311: ICE in generate_finalization_wrapper, at fortran/class.c:1992
- Authentication-results: sourceware.org; auth=none
- References: <CAKwh3qjvAeNZfxALiXr5FLz4+8EJh3PVVm3d5rakP=OfWk4AQA@mail.gmail.com> <9cc9085f-e75e-81c6-fb9b-ab3307d4634a@charter.net>
2017-05-09 18:18 GMT+02:00 Jerry DeLisle <jvdelisle@charter.net>:
> On 05/08/2017 02:16 PM, Janus Weil wrote:
>> Hi all,
>>
>> the attached patch fixes an ICE-on-valid problem with finalization by
>> making sure that the finalization procedures are properly resolved.
>>
>> In the test case, the finalizer of the component type was not being
>> resolved if the superordinate type had a finalizer itself.
>>
>> The patch also fixes a small error that had no actual impact on the
>> test case ('has_final2' could never become true).
>>
>> Regtesting went well, except for these three failure which also seems
>> to occur on a clean trunk currently:
>>
>> FAIL: gfortran.dg/coarray_lock_7.f90 -O scan-tree-dump-times original
>> FAIL: gfortran.dg/coarray_lock_7.f90 -O scan-tree-dump-times original
>> FAIL: gfortran.dg/mvbits_7.f90 -O0 (test for warnings, line 28)
>>
>> Ok for trunk?
>
> Yes Ok and thanks for patch.
Thanks, Jerry. Committed as r247818.
Cheers,
Janus