This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH][ARM] Remove movdi_vfp_cortexa8
- From: Wilco Dijkstra <Wilco dot Dijkstra at arm dot com>
- To: Richard Earnshaw <Richard dot Earnshaw at arm dot com>, GCC Patches <gcc-patches at gcc dot gnu dot org>
- Cc: nd <nd at arm dot com>
- Date: Fri, 5 May 2017 14:27:34 +0000
- Subject: Re: [PATCH][ARM] Remove movdi_vfp_cortexa8
- Authentication-results: sourceware.org; auth=none
- Authentication-results: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=arm.com;
- Nodisclaimer: True
- References: <VI1PR0802MB262138D6011F3C17FCD7B139838D0@VI1PR0802MB2621.eurprd08.prod.outlook.com>,<f831ac4f-0e43-247e-4b05-570a239144d4@arm.com>
- Spamdiagnosticmetadata: NSPM
- Spamdiagnosticoutput: 1:99
Richard Earnshaw (lists) wrote:
> (define_insn "*movdi_vfp"
> - [(set (match_operand:DI 0 "nonimmediate_di_operand" "=r,r,r,r,q,q,m,w,r,w,w, Uv")
> + [(set (match_operand:DI 0 "nonimmediate_di_operand" "=r,r,r,r,q,q,m,w,!r,w,w, Uv")
> Why have you introduced a no-reloads block on the 9th alternative for
> all variants?
That is the default behaviour when you don't explicitly set a cpu, so I kept that.
See https://patches.linaro.org/patch/541/ for the original reason for adding it -
duplicating this pattern was a mistake since '!' wouldn't pessimize other cores
as int<->fp moves typically have a non-trivial cost.
However given Cortex-A8 is ancient now we could just remove the '!'.
Wilco