This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [testsuite] Add missing dg-require-effective-target alloca to gcc testsuite
- From: Jakub Jelinek <jakub at redhat dot com>
- To: Tom de Vries <Tom_deVries at mentor dot com>
- Cc: Mike Stump <mikestump at comcast dot net>, Rainer Orth <ro at CeBiTec dot Uni-Bielefeld dot DE>, Richard Biener <richard dot guenther at gmail dot com>, GCC Patches <gcc-patches at gcc dot gnu dot org>
- Date: Wed, 26 Apr 2017 13:57:38 +0200
- Subject: Re: [testsuite] Add missing dg-require-effective-target alloca to gcc testsuite
- Authentication-results: sourceware.org; auth=none
- Authentication-results: ext-mx07.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
- Authentication-results: ext-mx07.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=jakub at redhat dot com
- Dkim-filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 89A1AC04B923
- Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 89A1AC04B923
- References: <D1217D9D-577A-485D-9275-8EC042115599@comcast.net> <336349f0-b973-77c0-c5f5-710240312270@mentor.com> <yddy3vuc0j8.fsf@CeBiTec.Uni-Bielefeld.DE> <CAFiYyc1fCUGQNOrh4ZwPgu9uqpmmBC_-3rJFvNrt7bW13jmCog@mail.gmail.com> <yddtw6ic09r.fsf@CeBiTec.Uni-Bielefeld.DE> <yddpoh6bzm9.fsf@CeBiTec.Uni-Bielefeld.DE> <587C88D3-2CEA-4E54-899E-ADFE8FBB6DC4@comcast.net> <ecd618b5-6cfa-5091-e1ce-edc5d555855c@mentor.com> <d453445e-54be-d3b5-cc27-d73bdbcc855d@mentor.com> <f7237b02-7f3b-552d-7c9c-2f03c40bdc22@mentor.com>
- Reply-to: Jakub Jelinek <jakub at redhat dot com>
On Wed, Apr 26, 2017 at 01:48:03PM +0200, Tom de Vries wrote:
> [ reposting with patch removed, was too big for gcc-patches@ ]
I see in various tests you've ended up with ... { target ... } . }
I think it would be better to just use ... { target ... } }
in that case, . is the default, and if target is *-*-*, also remove the {
target ... }.
Are there any spots where the relative line number is with too big bias
(say .+10 or .-10 and more)? I guess those should be decided case by case
whether we want relative, absolute or saved line numbers. If the
diagnostic is within the same function or code block as the stuff it is
relative to, relative is fine, but if e.g. the messages are just at the end
of file and there are unrelated functions in between, it is not a good idea
to use relative.
Jakub