This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH, rs6000] pr80482 Relax vector builtin parameter checks
- From: Jakub Jelinek <jakub at redhat dot com>
- To: Segher Boessenkool <segher at kernel dot crashing dot org>
- Cc: Bill Seurer <seurer at linux dot vnet dot ibm dot com>, gcc-patches at gcc dot gnu dot org
- Date: Tue, 25 Apr 2017 09:44:48 +0200
- Subject: Re: [PATCH, rs6000] pr80482 Relax vector builtin parameter checks
- Authentication-results: sourceware.org; auth=none
- Authentication-results: ext-mx07.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
- Authentication-results: ext-mx07.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=jakub at redhat dot com
- Dkim-filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 75481C04B95B
- Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 75481C04B95B
- References: <c7c6490e-9c6d-f01c-5633-235656214745@linux.vnet.ibm.com> <20170425045802.GE3751@gate.crashing.org>
- Reply-to: Jakub Jelinek <jakub at redhat dot com>
On Mon, Apr 24, 2017 at 11:58:03PM -0500, Segher Boessenkool wrote:
> On Mon, Apr 24, 2017 at 05:38:58PM -0500, Bill Seurer wrote:
> > [PATCH, rs6000] pr80482 Relax vector builtin parameter checks
> >
> > This patch changes the parameter testing for powerpc vector builtins to relax
> > the existing requirement that the parameters be identical to instead that they
> > be compatible. This allows for mixing parameters with differing qualified
> > (const, volatile, etc.) types.
> >
> > See https://gcc.gnu.org/bugzilla/show_bug.cgi?id=80482 for more information.
> >
> > Bootstrapped and tested on powerpc64le-unknown-linux-gnu and
> > powerpc64be-unknown-linux-gnu with no regressions. Is this ok for trunk?
>
> It looks fine to me, okay for trunk, thanks (with Jakub's comment taken
> care of).
>
> Also okay for the 7 branch if the RMs agree (it fixes a regression from
> GCC 6 and it seems unlikely to cause new problems).
Ok for 7.1 if you commit soon.
Jakub