This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Add gcc_jit_type_get_aligned
- From: David Malcolm <dmalcolm at redhat dot com>
- To: Florian Weimer <fw at deneb dot enyo dot de>
- Cc: 정인배(Inbae "Jeong)" <kukyakya at gmail dot com>, jit at gcc dot gnu dot org, gcc-patches at gcc dot gnu dot org
- Date: Mon, 24 Apr 2017 16:34:16 -0400
- Subject: Re: [PATCH] Add gcc_jit_type_get_aligned
- Authentication-results: sourceware.org; auth=none
- Authentication-results: ext-mx04.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
- Authentication-results: ext-mx04.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=dmalcolm at redhat dot com
- Dkim-filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 45F8F8046A
- Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 45F8F8046A
- References: <87y3vmse4n.fsf@mid.deneb.enyo.de> <1490994792-6645-1-git-send-email-dmalcolm@redhat.com>
On Fri, 2017-03-31 at 17:13 -0400, David Malcolm wrote:
> On Thu, 2017-03-30 at 22:28 +0200, Florian Weimer wrote:
> > * David Malcolm:
> >
> > > Here's a work-in-progress implementation of the idea, adding this
> > > entrypoint to the API:
> > >
> > > extern gcc_jit_type *
> > > gcc_jit_type_get_aligned (gcc_jit_type *type,
> > > unsigned int alignment_in_bytes);
> >
> > Should be size_t, not unsigned int. A 2**31 alignment isn't as
> > ridiculous as it might seem. x86-64 already has a 2**30 alignment
> > requirement in some contexts.
>
> Thanks; fixed in this version.
>
> Here's a completed version of the patch.
>
> It also implements the missing C++ binding
> gccjit::type::get_const, needed by a test case.
>
> Successfully bootstrapped®rtested on x86_64-pc-linux-gnu.
> Takes jit.sum from 8609 to 9349 PASS results.
>
> Release managers: is it acceptable to commit this to trunk in
> stage 4? It purely touches jit-related code/testcases, but I
> appreciate it's very late to be adding features.
>
> Otherwise I'll commit it in the next stage 1.
I've committed this to trunk (for gcc 8) as r247111.
[...snip...]