This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Do not instrument register variables in object-size sanitizer (PR sanitizer/80387).


On 04/11/2017 02:52 PM, Jakub Jelinek wrote:
> On Tue, Apr 11, 2017 at 02:33:52PM +0200, Martin Liška wrote:
>> --- /dev/null
>> +++ b/gcc/testsuite/gcc.dg/ubsan/pr70878.c
>> @@ -0,0 +1,9 @@
>> +/* PR sanitizer/80878 */
>> +/* { dg-do compile { target { x86_64-*-* } } } */
> 
> The target looks wrong.  In any case, it should be
> i?86-*-* x86_64-*-*, e.g. on Solaris it is a multilib
> compiler with -m32 default and -m64 optional.
> Then the question is if you really need lp64 for the test
> or not.  So either:
> /* { dg-do compile { target { i?86-*-* x86_64-*-* } } } */
> and then guard the dg-warning with { target lp64 },
> or
> /* { dg-do compile { target { { i?86-*-* x86_64-*-* } && lp64 } } } */
> 
> Please test the testcase with
> make check-gcc RUNTESTFLAGS='--target_board=unix\{-m32,-m64\} ubsan.exp=pr70878.c'
> Ok with one of those changes.

Thanks for help! I decided for the second variant. Survives the make check-gcc.
Installed as r246837.

Btw. I did typo in PR number, it's 70878 (fixed in changelog entry).

Martin

> 
> 	Jakub
> 


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]