This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH, GCC/ARM, Stage 1] Rename FPSCR builtins to correct names
- From: Prakhar Bahuguna <prakhar dot bahuguna at arm dot com>
- To: <gcc-patches at gcc dot gnu dot org>
- Cc: <nd at arm dot com>, <Richard dot Earnshaw at arm dot com>, <Ramana dot Radhakrishnan at arm dot com>, <Kyrylo dot Tkachov at arm dot com>
- Date: Mon, 10 Apr 2017 13:26:03 +0100
- Subject: Re: [PATCH, GCC/ARM, Stage 1] Rename FPSCR builtins to correct names
- Authentication-results: sourceware.org; auth=none
- Authentication-results: gcc.gnu.org; dkim=none (message not signed) header.d=none;gcc.gnu.org; dmarc=none action=none header.from=arm.com;
- Nodisclaimer: True
- References: <20170322104630.z7g7nk6sv2xdzhad@e107464-lin.cambridge.arm.com>
- Spamdiagnosticmetadata: NSPM
- Spamdiagnosticoutput: 1:99
On 22/03/2017 10:46:30, Prakhar Bahuguna wrote:
> The GCC documentation in section 6.60.8 ARM Floating Point Status and Control
> Intrinsics states that the FPSCR register can be read and written to using the
> intrinsics __builtin_arm_get_fpscr and __builtin_arm_set_fpscr. However, these
> are misnamed within GCC itself and these intrinsic names are not recognised.
> This patch corrects the intrinsic names to match the documentation, and adds
> tests to verify these intrinsics generate the correct instructions.
>
> Testing done: Ran regression tests on arm-none-eabi for Cortex-M4.
>
> 2017-03-09 Prakhar Bahuguna <prakhar.bahuguna@arm.com>
>
> gcc/ChangeLog:
>
> * gcc/config/arm/arm-builtins.c (arm_init_builtins): Rename
> __builtin_arm_ldfscr to __builtin_arm_get_fpscr, and rename
> __builtin_arm_stfscr to __builtin_arm_set_fpscr.
> * gcc/testsuite/gcc.target/arm/fpscr.c: New file.
>
> Okay for stage 1?
>
> --
>
> Prakhar Bahuguna
Bumping, could I get a review for this please?
Thanks,
--
Prakhar Bahuguna