This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [hsa] Integrate into the existing accelerator framework, libgomp plugin
- From: Martin Jambor <mjambor at suse dot cz>
- To: Thomas Schwinge <thomas at codesourcery dot com>
- Cc: Jakub Jelinek <jakub at redhat dot com>, gcc-patches at gcc dot gnu dot org
- Date: Sun, 9 Apr 2017 18:15:26 +0200
- Subject: Re: [hsa] Integrate into the existing accelerator framework, libgomp plugin
- Authentication-results: sourceware.org; auth=none
- References: <20150609144356.GB7122@virgil.suse> <87shlngvar.fsf@euler.schwinge.homeip.net>
On Wed, Apr 05, 2017 at 09:36:44AM +0200, Thomas Schwinge wrote:
> Hi!
>
> On Tue, 9 Jun 2015 16:43:57 +0200, Martin Jambor <mjambor@suse.cz> wrote:
> > [hsa libgomp plugin]
>
> > I'm looking forward to any comments and suggestions, meanwhile I have
> > committed the patch to the branch as r224284.
>
> Commenting better late than never? ;-)
>
> Is there a specific reason why you're not using the standard
> GOMP_PLUGIN_debug interface guarded by the GOMP_DEBUG environment
> variable, and instead essentially re-implement that functionality guarded
> by a new HSA_DEBUG environment variable? (I might be talked into
> creating the obvious patch.)
No, no reason at all, I did not now about GOMP_PLUGIN_debug. You're
welcome to create the patch (or I will do that after I wade through my
email and other backlogs).
Thanks for pointing it out,
Martin