This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Patch ping
- From: Jeff Law <law at redhat dot com>
- To: Jakub Jelinek <jakub at redhat dot com>, Jason Merrill <jason at redhat dot com>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Fri, 31 Mar 2017 09:14:54 -0600
- Subject: Re: Patch ping
- Authentication-results: sourceware.org; auth=none
- Authentication-results: ext-mx07.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
- Authentication-results: ext-mx07.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=law at redhat dot com
- Dkim-filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 63141C04D2A3
- Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 63141C04D2A3
- References: <20170331063658.GA17462@tucnak>
On 03/31/2017 12:36 AM, Jakub Jelinek wrote:
Hi!
I'd like to ping two patches:
PR c++/79572
- ubsan instrumentation of reference binding to NULL if the reference
is folded into INTEGER_CST with REFERENCE_TYPE
http://gcc.gnu.org/ml/gcc-patches/2017-03/msg01255.html
PR debug/79255
- dwarf2out profiledbootstrap ICE while building gnat;
either the posted patch
http://gcc.gnu.org/ml/gcc-patches/2017-03/msg01257.html
or in gen_decl_die:
case FUNCTION_DECL:
+ /* decl is NULL only if when processing a function declaration in
+ BLOCK_NONLOCALIZED_VARS. It is a normal declaration, not an
+ abstract copy of something, so make sure we don't handle it
+ like function inlined into something. */
+ if (decl == NULL_TREE)
+ {
+ decl = origin;
+ origin = NULL_TREE;
+ }
or something else (another possibility is to replace all decl
uses in case FUNCTION_DECL with decl_or_origin and
- if (!origin)
- origin = decl_class_context (decl);
+ if (!decl || !origin)
+ origin = decl_class_context (decl_or_origin);
I think I prefer your original approach -- pass in the original
FUNCTION_DECL. It seems to me like the other approaches are just
papering over the issue.
Original approach is OK for the trunk.
jeff