This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH][RFC] Fix P1 PR77498
- From: Jeff Law <law at redhat dot com>
- To: Richard Biener <rguenther at suse dot de>, gcc-patches at gcc dot gnu dot org
- Date: Wed, 29 Mar 2017 13:11:17 -0600
- Subject: Re: [PATCH][RFC] Fix P1 PR77498
- Authentication-results: sourceware.org; auth=none
- Authentication-results: ext-mx02.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
- Authentication-results: ext-mx02.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=law at redhat dot com
- Dkim-filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 88F0D883A6
- Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 88F0D883A6
- References: <alpine.LSU.2.20.1703291147460.30051@zhemvz.fhfr.qr>
On 03/29/2017 04:05 AM, Richard Biener wrote:
After quite some pondering over this and other related bugs I propose
the following for GCC 7 which tames down PRE a bit (back to levels
of GCC 6). Technically it's the wrong place to fix this, we do
have measures in place during elimination but they are not in effect
at -O2. For GCC 8 I'd like to be more aggressive there but that
would require to enable predictive commoning at -O2 (with some
limits to its unrolling) to not lose optimization opportunities.
The other option is to ignore this issue and postpone the solution
to GCC 8.
Bootstrapped / tested on x86_64-unknown-linux-gnu.
Any preference?
Thanks,
Richard.
2017-03-29 Richard Biener <rguenther@suse.de>
PR tree-optimization/77498
* tree-ssa-pre.c (phi_translate_1): Do not allow simplifications
to non-constants over backedges.
* gfortran.dg/pr77498.f: New testcase.
I've got a slight preference for this patch.
If you had a good start on the real fix then I'd lean more towards
postponing.
jeff