This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Fix PR80029
- From: Jakub Jelinek <jakub at redhat dot com>
- To: Cesar Philippidis <cesar at codesourcery dot com>
- Cc: "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>
- Date: Wed, 22 Mar 2017 14:50:19 +0100
- Subject: Re: [PATCH] Fix PR80029
- Authentication-results: sourceware.org; auth=none
- Authentication-results: ext-mx03.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
- Authentication-results: ext-mx03.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=jakub at redhat dot com
- Dkim-filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 0337C80F6B
- Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 0337C80F6B
- References: <278ce4b7-cc02-453b-10fc-8094e9078d9a@codesourcery.com> <20170322134249.GE11094@tucnak> <e72ae0fd-d647-7ea6-ac84-3a44cdffd6e9@codesourcery.com>
- Reply-to: Jakub Jelinek <jakub at redhat dot com>
On Wed, Mar 22, 2017 at 06:48:09AM -0700, Cesar Philippidis wrote:
> On 03/22/2017 06:42 AM, Jakub Jelinek wrote:
>
> >> 2017-03-22 Cesar Philippidis <cesar@codesourcery.com>
> >>
> >> PR c++/80029
> >>
> >> gcc/
> >> * gimplify.c (is_oacc_declared): New function.
> >> (oacc_default_clause): Use it to set default flags for acc declared
> >> variables inside parallel regions.
> >> (gimplify_scan_omp_clauses): Strip firstprivate pointers for acc
> >> declared variables.
> >> (gimplify_oacc_declare): Gimplify the declare clauses. Add the
> >> declare attribute to any decl as necessary.
> >>
> >> libgomp/
> >> * testsuite/libgomp.oacc-c-c++-common/declare-vla.c: New test.
> >
> > Ok if testing passed.
>
> Yes it did. By the way, is there a way to automate valgrind testing, or
> is that something that require manual inspection?
--enable-checking=valgrind if you have enough CPU time to burn (like a
weekend for a single bootstrap+regtest).
Jakub